activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Date Tue, 16 Jan 2018 15:37:57 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794632
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
    @@ -273,6 +286,14 @@ public void setAddress(String address) {
           setSimpleAddress(SimpleString.toSimpleString(address));
        }
     
    +   public void setName(String name) {
    --- End diff --
    
    The address setter was added as part of an effort to make Artemis JNDI work properly in
Tomcat.  I assume it's needed here, but I'll remove it for simplicity's sake and it can be
added later if necessary.


---

Mime
View raw message