activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmesnil <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...
Date Tue, 16 Jan 2018 15:21:25 GMT
Github user jmesnil commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1778#discussion_r161789136
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
    @@ -309,7 +330,7 @@ public SimpleString getSimpleAddress() {
        }
     
        public String getName() {
    -      return simpleAddress.toString();
    +      return name == null ? simpleAddress.toString() : name.toString();
    --- End diff --
    
    if we use `address` instead of `null` when creating an ActiveMQDestination, we ensure
that the fields are always non-null and this method can just return `name.toString()`


---

Mime
View raw message