activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtully <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1759: [ARTEMIS-1241] check for FQQN and autoc...
Date Thu, 11 Jan 2018 12:52:53 GMT
Github user gtully commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1759#discussion_r160949474
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/FQQNOpenWireTest.java
---
    @@ -315,13 +314,13 @@ public void testVirtualTopicFQQN() throws Exception {
        }
     
        @Test
    -   @Ignore("need to figure auto bindings creation")
        public void testVirtualTopicFQQNAutoCreate() throws Exception {
           Connection exConn = null;
     
           SimpleString topic = new SimpleString("VirtualTopic.Orders");
           SimpleString subscriptionQ = new SimpleString("Consumer.A");
     
    +      // defaults are false via test setUp
    --- End diff --
    
    thanks @mtaylor  - I see, that getDefaultAddressRoutingType should only be used by auto
address creation. The queue routing type needs to be figured out from the address.


---

Mime
View raw message