activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1758: More fixes around compatibility
Date Tue, 09 Jan 2018 15:26:12 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1758#discussion_r160436610
  
    --- Diff: tests/compatibility-tests/src/main/resources/servers/hornetqServer.groovy ---
    @@ -19,7 +23,7 @@ import org.hornetq.core.config.impl.ConfigurationImpl
     import org.hornetq.core.remoting.impl.netty.NettyAcceptorFactory
     import org.hornetq.core.remoting.impl.netty.TransportConstants
     import org.hornetq.jms.server.config.impl.JMSConfigurationImpl
    -import org.hornetq.jms.server.config.impl.JMSQueueConfigurationImpl
    +import org.hornetq.jms.server.config.impl.*
    --- End diff --
    
    I will keep this one as is actually... I have no help from the IDE on what classes to
import as this is hornetq... (It wasn't part of my change now anyways).
    
    
    (this is the reason I'm using groovy.. I can tweak the classloader.. and have no direct
dependency on the project.. totally optional. even the scan is done by a plugin.


---

Mime
View raw message