activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtully <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1759: [ARTEMIS-1241] check for FQQN and autocreate q...
Date Tue, 09 Jan 2018 12:54:11 GMT
Github user gtully commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1759
  
    I added to some existing auto create address logic in the code path which suffices for
my test case. It does appear a little hacky to have three xxToUse local variables and the
toString messing on simpleString does not look right. 
    One thought was to pass a null routingtype to this method but it is not clear to me where
that decision should be made. Pulling the value from config for the auto creation case does
make sense however.
    Please review and maybe it is time to consider pulling all of the auto creation logic
into one place.


---

Mime
View raw message