activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1752: ARTEMIS-1586 Reduce GC pressure due to String ...
Date Sat, 06 Jan 2018 07:46:34 GMT
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1752
  
    @clebertsuconic tbh, i can see the saving on property keys, and address per session.
    
    Also within the consumer and producer (though for producing the saving would be on String
to SimpleString for the keys so one extra variation needed), if you think typically a producer
would send typically to one or a few destinations and then send a million of them, like wise
on message properties, if you set one you're most likely to set it all the time, and then
again typically a consumer would see all the same. 
    
    The only bit I'm dubious on its benefit is property values.
    
    Lastly on the implementation detail this i think needs some work/cleanup, though after
finding/understanding through the discussion with @franz1981  its more of a last seen cache/pool
so I'm more +1 it, just the name made me to expect something different at first.


---

Mime
View raw message