Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E5BE2200D5F for ; Mon, 18 Dec 2017 09:05:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E43B2160C05; Mon, 18 Dec 2017 08:05:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D5BA160BF9 for ; Mon, 18 Dec 2017 09:05:20 +0100 (CET) Received: (qmail 34943 invoked by uid 500); 18 Dec 2017 08:05:19 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 34922 invoked by uid 99); 18 Dec 2017 08:05:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Dec 2017 08:05:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 75101DFC32; Mon, 18 Dec 2017 08:05:18 +0000 (UTC) From: michaelandrepearce To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis issue #1684: ARTEMIS-1498: Openwire internal headers should... Content-Type: text/plain Message-Id: <20171218080518.75101DFC32@git1-us-west.apache.org> Date: Mon, 18 Dec 2017 08:05:18 +0000 (UTC) archived-at: Mon, 18 Dec 2017 08:05:21 -0000 Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1684 @RaiSaurabh this isn't what was quite meant, the idea of implementing Message is to avoid conversion, so it only needs to convert if cross protocol on consume. You have only extended and kept the conversion to CoreMessage, not entirely the intent expected. E.g. the idea is that you have similar to what occurs with AMQPMessage, that internally it is kept unconverted in AMQP form, so that if AMQP producer and AMQP consumer, it doesn't convert to CoreMessage. ---