Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 52DD8200D55 for ; Sat, 9 Dec 2017 15:57:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 515E2160C03; Sat, 9 Dec 2017 14:57:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8F774160C0E for ; Sat, 9 Dec 2017 15:57:04 +0100 (CET) Received: (qmail 99916 invoked by uid 500); 9 Dec 2017 14:57:03 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 99905 invoked by uid 99); 9 Dec 2017 14:57:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Dec 2017 14:57:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F160FE38B8; Sat, 9 Dec 2017 14:57:00 +0000 (UTC) From: michaelandrepearce To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #: Content-Type: text/plain Message-Id: <20171209145701.F160FE38B8@git1-us-west.apache.org> Date: Sat, 9 Dec 2017 14:57:00 +0000 (UTC) archived-at: Sat, 09 Dec 2017 14:57:05 -0000 Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/26752a7aafa5651e41abf23ac550c6c09bb08287#commitcomment-26165547 In tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java: In tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSClientTestSupport.java on line 237: Ah focus here was on getting LVQ working on AMQP, probably why didn't pick up on it, seems it won't on OpenWire, but we can support it relatively easily. Also test uses a few JMS 2.0 methods (un-neededly) so can update also. Ill raise a JIRA to support LVQ for OpenWire (as its a new feature) and in doing so this will be fixed up ---