activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...
Date Mon, 18 Dec 2017 14:24:46 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1722#discussion_r157496805
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ResponseCache.java
---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.protocol.core.impl;
    +
    +import java.util.concurrent.atomic.AtomicInteger;
    +
    +import org.apache.activemq.artemis.api.core.ActiveMQInterruptedException;
    +import org.apache.activemq.artemis.core.protocol.core.Packet;
    +import org.apache.activemq.artemis.core.protocol.core.ResponseHandler;
    +
    +public class ResponseCache {
    +
    +   private final AtomicInteger writerPointer = new AtomicInteger(0);
    +   private final AtomicInteger sequence = new AtomicInteger(0);
    +
    +   private final Packet[] store;
    +   private ResponseHandler responseHandler;
    +
    +   public ResponseCache(int size) {
    +      this.store = new Packet[size];
    +   }
    +
    +   public long add(Packet packet) {
    +      int pointer = writerPointer.getAndUpdate(operand -> {
    --- End diff --
    
    It depends on how it is accessed by concurrent writers ie `handleResponse` and `add` could
be accessed by different threads concurrently?
    
    Dealing with concurrent accesses here could be dangerous: If multiple threads are accessing
concurrently `Packet[]` and the references are not padded by 128 bytes (ie 4 object references
between the `Packet` references in the array) the cache won't scale due to false sharing


---

Mime
View raw message