activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1701: ARTEMIS-1542 - AMQP message cluster-bri...
Date Sun, 10 Dec 2017 02:39:48 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1701#discussion_r155936916
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
    @@ -608,7 +608,11 @@ public AMQPMessage setAddress(String address) {
     
        @Override
        public AMQPMessage setAddress(SimpleString address) {
    -      return setAddress(address.toString());
    +      if (address != null) {
    +        return setAddress(address.toString());
    +      } else {
    +        return null;
    --- End diff --
    
    shouldn't this be:
    
    
    return setAddress(null);
    
    ????


---

Mime
View raw message