activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1696: NO-JIRA fixed minor regression and brok...
Date Fri, 08 Dec 2017 08:24:17 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1696#discussion_r155723971
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
    @@ -1737,8 +1737,12 @@ public String listAddresses(String options, int page, int pageSize)
throws Excep
           try {
              final Set<SimpleString> addresses = server.getPostOffice().getAddresses();
              List<AddressInfo> addressInfo = new ArrayList<>();
    -         for (SimpleString address:addresses) {
    -            addressInfo.add(server.getPostOffice().getAddressInfo(address));
    +         for (SimpleString address : addresses) {
    +            AddressInfo info = server.getPostOffice().getAddressInfo(address);
    +            //ignore if no longer available
    +            if (info != null) {
    --- End diff --
    
    Nice check.


---

Mime
View raw message