Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D4C69200D34 for ; Fri, 3 Nov 2017 15:41:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D2C63160BFC; Fri, 3 Nov 2017 14:41:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1A466160BE9 for ; Fri, 3 Nov 2017 15:41:07 +0100 (CET) Received: (qmail 51629 invoked by uid 500); 3 Nov 2017 14:41:07 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 51607 invoked by uid 99); 3 Nov 2017 14:41:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 14:41:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E3E20DFBD3; Fri, 3 Nov 2017 14:41:06 +0000 (UTC) From: franz1981 To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #1638: ARTEMIS-1499 ArtemisExecutor and Proces... Content-Type: text/plain Message-Id: <20171103144106.E3E20DFBD3@git1-us-west.apache.org> Date: Fri, 3 Nov 2017 14:41:06 +0000 (UTC) archived-at: Fri, 03 Nov 2017 14:41:09 -0000 Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1638#discussion_r148800347 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ProcessorBase.java --- @@ -109,12 +125,49 @@ public final boolean isFlushed() { return stateUpdater.get(this) == STATE_NOT_RUNNING; } - protected void task(T command) { - tasks.add(command); --- End diff -- It is not only the flush that has issues but the execute too: take a look at the tests I've added :) ---