activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1659: ARTEMIS-1516 - Ensure JNDI via Tomcat R...
Date Fri, 17 Nov 2017 00:40:48 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1659#discussion_r151577088
  
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
    @@ -88,20 +83,6 @@
     
        private boolean finalizeChecks;
     
    -   @Override
    -   public void writeExternal(ObjectOutput out) throws IOException {
    -      URI uri = toURI();
    -
    -      try {
    -         out.writeUTF(uri.toASCIIString());
    --- End diff --
    
    Wouldn't this will break compatibility.
    Think of anyone serializing this class.
    
    Looking at the JNDISTorage (new class) I see that this is calling now writeObject(getProperties());
    
    As opposed to the writeURI.
    
    The point was to write a string to be better compatible between versions.
    
    Can we add back the format we had here?


---

Mime
View raw message