activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1622: ARTEMIS-1485 ActiveMQTestBase.threadDum...
Date Tue, 31 Oct 2017 03:00:47 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1622#discussion_r147885701
  
    --- Diff: artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
---
    @@ -619,34 +623,107 @@ public static void checkWeakReferences(final WeakReference<?>...
references) {
        }
     
        public static String threadDump(final String msg) {
    -      StringWriter str = new StringWriter();
    -      PrintWriter out = new PrintWriter(str);
     
    -      Map<Thread, StackTraceElement[]> stackTrace = Thread.getAllStackTraces();
    +      try (
    --- End diff --
    
    Hmmmm... now that you have something complete like this.. we need to think of a way to
reuse this logic into ActiveMQServerImpl::threadDump


---

Mime
View raw message