activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <>
Subject [GitHub] activemq-artemis pull request #1605: ARTEMIS-1476 HdrHistogram support on ve...
Date Tue, 24 Oct 2017 19:43:47 GMT
Github user michaelandrepearce commented on a diff in the pull request:
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/
    @@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
                                    String fileName,
                                    int maxAIO,
                                    JournalType journalType) throws Exception {
    -      SequentialFileFactory factory = newFactory(datafolder, fsync, journalType, blockSize
* blocks, maxAIO);
    +      final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
    --- End diff --
    For me trying to understand the code just for a review and understand the differences/changes
right now is a bit hard, as too much has moved, its not impossible just is making it tricky
to be sure.
    If you're not too much against it, it might be easier to do the "if", then it is simply
cleaner / easier from a review POV to see what is changed / get comfortable that actually
the old behaviour is as is.
    Then anyhow as we get more confident it might the if statement always equates to true
anyhow and the other side of the if block is removed entirely.


View raw message