activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <>
Subject [GitHub] activemq-artemis pull request #1605: ARTEMIS-1476 HdrHistogram support on ve...
Date Tue, 24 Oct 2017 16:50:17 GMT
Github user franz1981 commented on a diff in the pull request:
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/
    @@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
                                    String fileName,
                                    int maxAIO,
                                    JournalType journalType) throws Exception {
    -      SequentialFileFactory factory = newFactory(datafolder, fsync, journalType, blockSize
* blocks, maxAIO);
    +      final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
    --- End diff --
    TBH I've provided a couple of fixes too  :P: like the one on the file size with `alignment
!= 1`.
    I've tried to have a common logic while grouping the differences in order to have a simpler
and maintainable code: probably that's the reason why you are seeing such differences on the
source code.
    I've already evaluated (ie JitWatch on the rescue) such abstraction won't affect the performance
of the 2 cases, but if you think that is better to put everything under a big `if (verbose)`
I can understand your reasons too: that's why having 6 eyes on it is more than wellcome IMO


View raw message