activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1605: ARTEMIS-1476 HdrHistogram support on ve...
Date Mon, 23 Oct 2017 18:30:20 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1605#discussion_r146354093
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
---
    @@ -193,18 +291,29 @@ private static SequentialFileFactory newFactory(File datafolder,
boolean datasyn
     
              case NIO:
                 factory = new NIOSequentialFileFactory(datafolder, 1).setDatasync(datasync);
    -            ((NIOSequentialFileFactory) factory).disableBufferReuse();
    +            if (bufferReuse) {
    +               ((NIOSequentialFileFactory) factory).enableBufferReuse();
    --- End diff --
    
    This is also wrong... you are changing the semantic of this test...
    
    
    We are measuring how much write the system can do... Using the buffer will defeat the
purpose of the test...
    
    
    Besides you are using the timeouts from where? this is not the intention of this calculation.


---

Mime
View raw message