activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1592: NO-JIRA improve MQTT protocol logging
Date Wed, 18 Oct 2017 13:07:55 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1592#discussion_r145407743
  
    --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
    @@ -67,6 +76,8 @@
     
        public static final int DEFAULT_KEEP_ALIVE_FREQUENCY = 5000;
     
    +   public static final String logUTF8PublishPayload = System.getProperty("org.apache.activemq.artemis.core.protocol.mqtt.logUTF8PublishPayload");
    --- End diff --
    
    this is about tracing.. why don't you just always log the UTF?
    if you don't need that level of information, just take trace out.
    
    
    of you could do something like.. have this whole thing at debug... and if trace, throw
the body on log.trace.
    
    The system property is a bit odd here. 


---

Mime
View raw message