activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1578: ARTEMIS-1452 Improvements to IO parameters and...
Date Fri, 06 Oct 2017 14:15:57 GMT
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1578
  
    @franz1981 https://github.com/apache/activemq-artemis/blob/37135617a8776c91c7e598ff11aa8bbc240ceafe/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java#L80-L83
    
    
    All you need is to set journal-timeout = 0... which wasn't being allowed on the config
(> 0).. I basically changed it allowing >= 0 and that's the change.
    
    
    Regarding MAPPED.. I didn't merge that one before because I thought we were lacking tests...
I had a test on my workspace for Unbuffered.. but I think I missed it...
    
    
    I think we should change the CLI to make timeout = 0 if sync = false (for all the journals..
not just MAPPED).  and add a text on the broker.xml saying we recommend disabling if sync=false.


---

Mime
View raw message