Return-Path: <dev-return-61180-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 0BC9A200CE6
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 15 Sep 2017 21:04:32 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 0A75B1609D1; Fri, 15 Sep 2017 19:04:32 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 46BAE1609C9
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 15 Sep 2017 21:04:31 +0200 (CEST)
Received: (qmail 4756 invoked by uid 500); 15 Sep 2017 19:04:29 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 4739 invoked by uid 99); 15 Sep 2017 19:04:29 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 19:04:29 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id F116BF55C8; Fri, 15 Sep 2017 19:04:28 +0000 (UTC)
From: jbertram <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1537-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1537-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1537: ARTEMIS-1422 Fix match change to suppor...
Content-Type: text/plain
Message-Id: <20170915190428.F116BF55C8@git1-us-west.apache.org>
Date: Fri, 15 Sep 2017 19:04:28 +0000 (UTC)
archived-at: Fri, 15 Sep 2017 19:04:32 -0000

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1537#discussion_r139227180
  
    --- Diff: tests/integration-tests/src/test/resources/reload-address-queues-updated.xml ---
    @@ -111,7 +111,12 @@ under the License.
                 <config-delete-addresses>FORCE</config-delete-addresses>
              </address-setting>
           </address-settings>
    -      
    +
    +      <wildcard-addresses>
    +         <enabled>true</enabled>
    --- End diff --
    
    FWIW, the matching logic will use the configured <delimiter>, <any-words>, and <single-word> regardless of how <enabled> is set.  However, the routing logic won't.  Not sure if we want to make those semantics match (no pun intended).


---