Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1530-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1530-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1530: ARTEMIS-1417 Failback not working on NF...
Content-Type: text/plain
Message-Id: <20170912163820.272BBF5724@git1-us-west.apache.org>
Date: Tue, 12 Sep 2017 16:38:20 +0000 (UTC)
archived-at: Tue, 12 Sep 2017 16:38:22 -0000

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1530#discussion_r138402896
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java ---
    @@ -267,25 +293,27 @@ public final SimpleString readNodeId() throws ActiveMQIllegalStateException, IOE
           return getNodeId();
        }
     
    -   protected FileLock tryLock(final int lockPos) throws Exception {
    +   protected FileLock tryLock(final long lockPos) throws IOException {
    --- End diff --
    
    lock is changed from int to long here, was there a need? 
    
    if so other methods such as lock should be updated, if not this should be reverted


---