Return-Path: <dev-return-61034-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 42527200CF0
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  7 Sep 2017 08:38:06 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 40C87161CDC; Thu,  7 Sep 2017 06:38:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id AD74C161CAD
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  7 Sep 2017 08:38:05 +0200 (CEST)
Received: (qmail 9453 invoked by uid 500); 7 Sep 2017 06:38:04 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 9441 invoked by uid 99); 7 Sep 2017 06:38:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Sep 2017 06:38:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 17AE2F553D; Thu,  7 Sep 2017 06:38:04 +0000 (UTC)
From: franz1981 <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1515-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1515-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1515: ARTEMIS-1393 CriticalAnalyzer timeout u...
Content-Type: text/plain
Message-Id: <20170907063804.17AE2F553D@git1-us-west.apache.org>
Date: Thu,  7 Sep 2017 06:38:04 +0000 (UTC)
archived-at: Thu, 07 Sep 2017 06:38:06 -0000

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1515#discussion_r137456469
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalMeasure.java ---
    @@ -17,28 +17,39 @@
     
     package org.apache.activemq.artemis.utils.critical;
     
    -import org.jboss.logging.Logger;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.atomic.AtomicLongFieldUpdater;
     
    -public class CriticalMeasure {
    +final class CriticalMeasure {
     
    -   private static final Logger logger = Logger.getLogger(CriticalMeasure.class);
    +   //uses updaters to avoid creates many AtomicLong instances
    +   private static final AtomicLongFieldUpdater<CriticalMeasure> TIME_ENTER_UPDATER = AtomicLongFieldUpdater.newUpdater(CriticalMeasure.class, "timeEnter");
    +   private static final AtomicLongFieldUpdater<CriticalMeasure> TIME_LEFT_UPDATER = AtomicLongFieldUpdater.newUpdater(CriticalMeasure.class, "timeLeft");
     
    -   private volatile long timeEnter;
    -   private volatile long timeLeft;
    +   //System::nanoTime can't reach this value so it's the best candidate to have a NULL semantic
    +   private static final long NIL = Long.MAX_VALUE;
    --- End diff --
    
    I can do an approximation of the original logic by initializing both the variables to Long.MIN in order to maintain this logic simple as the original one and to cover the case where only timeLeft is not initialized with nanoTime calls negative.


---