Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1502-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1502-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1502: [ARTEMIS-1382] Improve artemis-server l...
Content-Type: text/plain
Message-Id: <20170901142929.49039F55E6@git1-us-west.apache.org>
Date: Fri,  1 Sep 2017 14:29:29 +0000 (UTC)
archived-at: Fri, 01 Sep 2017 14:29:32 -0000

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1502#discussion_r136587775
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/LargeServerMessageImpl.java ---
    @@ -178,7 +178,7 @@ private void checkDelete() throws Exception {
              try {
                 deleteFile();
              } catch (Exception e) {
    -            ActiveMQServerLogger.LOGGER.error(e.getMessage(), e);
    --- End diff --
    
    why not simply add tcall the error.. we don't need a special logger here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---