activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clebert Suconic <clebert.suco...@gmail.com>
Subject Re: Artemis wildcard matching bug
Date Wed, 06 Sep 2017 16:43:03 GMT
Makes sense to me.

I hope it's not a version compatibility breaker thought.

On Wed, Sep 6, 2017 at 12:39 PM Christopher Shannon <
christopher.l.shannon@gmail.com> wrote:

> I noticed a difference with wildcard matching in Artemis from 5.x and I
> think the Artemis version is wrong.
>
> Let's take the following wildcard pattern as an example in Artemis:
> *a.b.c.#*
>
> Pattern   Matches?
> a.b.c         yes
> a.b.c.d      yes
> a.b.cabd   yes
>
> Example in ActiveMQ 5.x: *a.b.c.>*
>
> Pattern   Matches?
> a.b.c         yes
> a.b.c.d      yes
> a.b.cabd   no
>
> It does not make sense to me that a.b.cabd would match a.b.c.#.  This
> happens because the matching logic just replaces .# with .* in a regex
> matching pattern so it matches 0 or many characters.  There is a delimiter
> there so I think the 5.x approach is correct.  Also maybe we should allow
> user's to be able to plug in custom matching logic to override the default?
>  (This is something i can do in a PR)
>
> Thoughts?
>
-- 
Clebert Suconic

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message