activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Bish <tabish...@gmail.com>
Subject Re: [CANCEL] [VOTE] Apache ActiveMQ Artemis 2.3.0
Date Fri, 01 Sep 2017 21:17:52 GMT
On 09/01/2017 05:12 PM, Clebert Suconic wrote:
> worked for me: both on my local mac, remote server and another linux I
> have access.. all succeeded:
>
> https://gist.github.com/clebertsuconic/9f8fbbe7041439eda623cf22206c0dae
>
>
> Instead of me figuring out your env:
>
> - after rebasing artemis, mvn clean, and rebuild your workspace
> - go to artemis-distribution/src/test/scripts
> - run ./validate-spaces.sh
>
>
> if it is passing, please try to simulate the exact combination you
> use.. if you make it fail please send a commit or PR towards this
> scripting test.
>
>
>
> This shouldn't be a reason for -1 anyways... but I will wait until
> tuesday after the holiday to retag the release. I pushed once and
> maven upload failed.. it's getting too close to Saturday now.. I will
> do it after the holiday.
>
>

I didn't actually -1 the vote to begin with, if you read it that way 
maybe there's something wrong with your environment.

>
>
>
> On Fri, Sep 1, 2017 at 3:15 PM, Timothy Bish <tabish121@gmail.com> wrote:
>> On 09/01/2017 02:35 PM, Clebert Suconic wrote:
>>> I have tried infinite variations.. windows, linux, mac.. couldn't
>>> replicate the Logger issue...
>>>
>>>
>>> We actually test spaces on the CLI testsuite. so I will assume you had
>>> something wrong on your environment... I will retag now.
>>
>> Hard to think of an issue that is environment related for two steps required
>> to reproduce here
>>
>> run "./bin/artemis create test" from dir with space, then in the test dir
>> created run "./bin/atremis run"
>>
>> reproduces every time here, if you'd like to suggest how my environment is
>> "messed up" please provide suggestions.
>>
>>
>>> On Fri, Sep 1, 2017 at 10:42 AM, Clebert Suconic
>>> <clebert.suconic@gmail.com> wrote:
>>>> I will retag based on the feedback..
>>>>
>>>> thanks for catching these issues...
>>>>
>>>>
>>>> I still didn't reproduce the Logger issue though.. tried with many
>>>> environments.. different settings.. and nothing so far.
>>>>
>>>> On Fri, Sep 1, 2017 at 8:37 AM, Clebert Suconic
>>>> <clebert.suconic@gmail.com> wrote:
>>>>> Consider it canceled. I will send a Cancel email when I get to a
>>>>> computer.
>>>>>
>>>>>
>>>>> One thing I will need is the exact sequence of comands Tim used to get
>>>>> the
>>>>> logger error.  Or if that was environmental.  I couldn't reproduce that
>>>>> on
>>>>> in different envs.
>>>>>
>>>>> On Fri, Sep 1, 2017 at 4:22 AM Martyn Taylor <mtaylor@redhat.com>
wrote:
>>>>>> -1.
>>>>>>
>>>>>> I managed to reproduce this.  In Firefox (which I rarely use), I
loaded
>>>>>> up
>>>>>> the console to be only to be greeted by the HawtIO branding... sigh...
>>>>>> After checking the localStorage settings from Michael's commit, I
could
>>>>>> see
>>>>>> that they were set to:
>>>>>>
>>>>>> theme="default"
>>>>>> branding="hawtio"
>>>>>>
>>>>>> A bit of digging shows that this is part of HawtIO proper:
>>>>>>
>>>>>>
>>>>>> https://github.com/hawtio/hawtio/blob/master/hawtio-web/src/main/webapp/app/themes/js/themesPlugin.ts#L57-L58
>>>>>>
>>>>>> If anyone has used any HawtIO plugin previously there's a potential
>>>>>> this
>>>>>> issue can surface for them.  Clebert, we will need to fix and rebuild.
>>>>>>
>>>>>> Michael I tested your patch and it solves the problem.  I have some
>>>>>> comments, I will post on the PR.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Sep 1, 2017 at 8:47 AM, Martyn Taylor <mtaylor@redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Tim,
>>>>>>>
>>>>>>> Are you sure your browser has not cached a previous version of
the
>>>>>>> HawtIO
>>>>>>> branding?  What happens if you run inside of private browse mode?
>>>>>>>
>>>>>>> On Fri, Sep 1, 2017 at 6:19 AM, Michael André Pearce <
>>>>>>> michael.andre.pearce@me.com> wrote:
>>>>>>>
>>>>>>>> Hi Guys,
>>>>>>>>
>>>>>>>> Like Clebert I cannot reproduce.
>>>>>>>>
>>>>>>>> I have a hunch I think what's going on, and have made a PR
to address
>>>>>>>> that if it is the case.
>>>>>>>>
>>>>>>>> But I really need a reproducer to test it, Tim I'm hoping
you can
>>>>>>>> help
>>>>>>>> us
>>>>>>>> here? I have tagged you both in the PR.
>>>>>>>>
>>>>>>>> Cheers
>>>>>>>> Mike
>>>>>>>>
>>>>>>>> Sent from my iPhone
>>>>>>>>
>>>>>>>> On 1 Sep 2017, at 02:05, Clebert Suconic <clebert.suconic@gmail.com>
>>
>>
>> --
>> Tim Bish
>> twitter: @tabish121
>> blog: http://timbish.blogspot.com/
>>
>
>

-- 
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/


Mime
View raw message