activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <>
Subject [GitHub] activemq-artemis pull request #1559: ARTEMIS-1441 Critical Analyzer Check Pe...
Date Thu, 28 Sep 2017 18:25:42 GMT
Github user clebertsuconic commented on a diff in the pull request:
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/
    @@ -147,6 +147,7 @@ public void run() {
                          // this means that the server has been stopped as we could acquire
the semaphore... returning now
    +                  logger.trace("Checking critical analyzer");
    --- End diff --
    nope.. not by mistake...
    I talked to the guy who wrote jboss-logging once... the issue that we would need if (logger.istTraceEnabled())
was for concatenations... this is a constant string.. and has no cost from a previous conversation...
    I can add the if (log.isTraceEnablled)... but it won't buy is much
    Besides.. this only happens every 2 minutes only.


View raw message