activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1539: MQTT work
Date Mon, 18 Sep 2017 14:03:57 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1539#discussion_r139431348
  
    --- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
---
    @@ -172,4 +177,8 @@ public void invokeIncoming(MqttMessage mqttMessage, MQTTConnection
connection) {
        public void invokeOutgoing(MqttMessage mqttMessage, MQTTConnection connection) {
           super.invokeInterceptors(this.outgoingInterceptors, mqttMessage, connection);
        }
    +
    +   public Map<String, MQTTConnection> getConnectedClients() {
    +      return connectedClients;
    --- End diff --
    
    In my opinion it's not really exposing class internals.  The method simply returns a Map.
 This same pattern is used all over the code-base.


---

Mime
View raw message