activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1537: ARTEMIS-1422 Fix match change to suppor...
Date Fri, 15 Sep 2017 18:45:08 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1537#discussion_r139223158
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/HierarchicalObjectRepository.java
---
    @@ -94,6 +99,11 @@
         */
        private final ArrayList<HierarchicalRepositoryChangeListener> listeners = new
ArrayList<>();
     
    +   public HierarchicalObjectRepository(final WildcardConfiguration wildcardConfiguration)
{
    --- End diff --
    
    I'd rather see a default constructor which calls this one so all the places in the code-base
which use the default WildcardConfiguration don't have to be changed to pass in `new WildcardConfiguration()`
or `null`.


---

Mime
View raw message