activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1534: ARTEMIS-1420 limit non-ssl connection h...
Date Wed, 13 Sep 2017 19:28:39 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1534#discussion_r138716284
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/ActiveMQChannelHandler.java
---
    @@ -89,6 +90,11 @@ public void exceptionCaught(final ChannelHandlerContext ctx, final
Throwable cau
           if (!active) {
              return;
           }
    +
    +      if (cause instanceof ReadTimeoutException) {
    +         ActiveMQClientLogger.LOGGER.error("Connection without communication timeout
has expired.");
    --- End diff --
    
    Should probably have a specific error code defined in ActiveMQClientLogger and use that.


---

Mime
View raw message