activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1530: ARTEMIS-1417 Failback not working on NF...
Date Tue, 12 Sep 2017 16:42:46 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1530#discussion_r138404056
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
---
    @@ -267,25 +293,27 @@ public final SimpleString readNodeId() throws ActiveMQIllegalStateException,
IOE
           return getNodeId();
        }
     
    -   protected FileLock tryLock(final int lockPos) throws Exception {
    +   protected FileLock tryLock(final long lockPos) throws IOException {
    --- End diff --
    
    java.nio.channels.FileChannel#tryLock takes longs so that's why I changed it.  I updated
the rest of the methods/variables to be consistent.


---

Mime
View raw message