activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From treblereel <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1502: [ARTEMIS-1382] Improve artemis-server l...
Date Mon, 04 Sep 2017 15:52:00 GMT
Github user treblereel commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1502#discussion_r136847154
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterManager.java
---
    @@ -542,15 +542,15 @@ public void clear() {
              try {
                 bridge.stop();
              } catch (Exception e) {
    -            ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e);
    --- End diff --
    
    It's a good example. How critical it is for us to log bridge.stop failure ? What is the
probability that this will happen? Maybe it's better for gss issue to have individual id for
this case?


---

Mime
View raw message