activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1501: ARTEMIS-1270 Enforce Theming
Date Fri, 01 Sep 2017 08:27:33 GMT
Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1501#discussion_r136523191
  
    --- Diff: artemis-hawtio/activemq-branding/src/main/webapp/plugin/js/plugin.js ---
    @@ -59,10 +59,14 @@ var activemqBranding = (function (self) {
     
         self.module = angular.module(self.pluginName, ['hawtioCore']);
         self.module.run(function (branding) {
    -        self.log.debug("ActivMQ theme loaded");
    +        self.log.info("ActiveMQ theme loaded");
    +        if (localStorage['theme'] != 'activemq' || localStorage['branding'] != 'activemq')
{
    +            localStorage['theme'] = 'activemq';
    +            localStorage['branding'] = 'activemq';
    +            location.reload();
    --- End diff --
    
    There are checks in this file to set the branding/theme if it's not already set.  Any
reason why you didn't just remove the if statements?
    
    ```js
        if (!localStorage['theme'])         if (!('theme' in localStorage)) {
                localStorage['theme'] = 'activemq';
        }
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message