Return-Path: <dev-return-60748-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3D80A200CED
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 18 Aug 2017 12:15:42 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 3BD9616C9D3; Fri, 18 Aug 2017 10:15:42 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A920116C9D2
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 18 Aug 2017 12:15:41 +0200 (CEST)
Received: (qmail 95748 invoked by uid 500); 18 Aug 2017 10:15:40 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 95737 invoked by uid 99); 18 Aug 2017 10:15:39 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 10:15:39 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9FF7CE0610; Fri, 18 Aug 2017 10:15:39 +0000 (UTC)
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1471-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1471-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Content-Type: text/plain
Message-Id: <20170818101539.9FF7CE0610@git1-us-west.apache.org>
Date: Fri, 18 Aug 2017 10:15:39 +0000 (UTC)
archived-at: Fri, 18 Aug 2017 10:15:42 -0000

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1471#discussion_r133925691
  
    --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
    @@ -44,9 +44,30 @@
                         </button>
                     </form>
                 </div>
    +
    +            <div class="pull-right">
    +              <form class="form-inline">
    +                <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length == 0"
    +                        ng-click="deleteDialog = true"
    +                        title="Close the selected Consumer">
    +                  <i class="icon-remove"></i> Close
    +                </button>
    +                &nbsp;&nbsp;&nbsp;
    +              </form>
    +            </div>
             </div>
         </div>
     
    +    <div hawtio-confirm-dialog="deleteDialog"
    +          ok-button-text="Close"
    +          on-ok="closeConsumer()">
    +       <div class="dialog-body">
    +         <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
    --- End diff --
    
    should this be 
    
    > You are about to close the selected **consumer**


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---