Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1443-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1443-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1443: ARTEMIS-1324 Deadlock detection and hea...
Content-Type: text/plain
Message-Id: <20170807214319.154A7F1755@git1-us-west.apache.org>
Date: Mon,  7 Aug 2017 21:43:19 +0000 (UTC)
archived-at: Mon, 07 Aug 2017 21:43:22 -0000

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131771146
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java ---
    @@ -2064,6 +2072,53 @@ public Configuration setNetworkCheckPing6Command(String command) {
           return this;
        }
     
    +   @Override
    +   public boolean isCriticalAnalyzer() {
    +      return criticalAnalyzer;
    +   }
    +
    +   @Override
    +   public Configuration setCriticalAnalyzer(boolean CriticalAnalyzer) {
    +      this.criticalAnalyzer = CriticalAnalyzer;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getCriticalAnalyzerTimeout() {
    +      return criticalAnalyzerTimeout;
    +   }
    +
    +   @Override
    +   public Configuration setCriticalAnalyzerTimeout(long timeout) {
    +      this.criticalAnalyzerTimeout = timeout;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getCriticalAnalyzerCheckPeriod() {
    +      if (criticalAnalyzerCheckPeriod <= 0) {
    --- End diff --
    
    agreed what is there is fine, these are only code nits


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---