Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: cshannon <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1445-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1445-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1445: ARTEMIS-1327 - Support checked exceptio...
Content-Type: text/plain
Message-Id: <20170807152204.24279E96E8@git1-us-west.apache.org>
Date: Mon,  7 Aug 2017 15:22:04 +0000 (UTC)
archived-at: Mon, 07 Aug 2017 15:22:06 -0000

Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1445#discussion_r131683225
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java ---
    @@ -537,7 +540,11 @@ public void connectionDestroyed(final Object connectionID) {
           if (conn != null && !conn.connection.isSupportReconnect()) {
              RemotingConnection removedConnection = removeConnection(connectionID);
              if (removedConnection != null) {
    -            server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterDestroyConnection(removedConnection) : null);
    +            try {
    +               server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterDestroyConnection(removedConnection) : null);
    +            } catch (Exception e) {
    +               throw new IllegalStateException("Error executing afterDestroyConnection plugin method: " + e.getMessage(), e);
    --- End diff --
    
    done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---