Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: michaelandrepearce <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1443-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1443-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1443: ARTEMIS-1324 Deadlock detection and hea...
Content-Type: text/plain
Message-Id: <20170806044800.39539E382D@git1-us-west.apache.org>
Date: Sun,  6 Aug 2017 04:48:00 +0000 (UTC)
archived-at: Sun, 06 Aug 2017 04:48:02 -0000

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534319
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java ---
    @@ -2064,6 +2072,53 @@ public Configuration setNetworkCheckPing6Command(String command) {
           return this;
        }
     
    +   @Override
    +   public boolean isAnalyzeCritical() {
    +      return analyzeCritical;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCritical(boolean analyzeCritical) {
    +      this.analyzeCritical = analyzeCritical;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalTimeout() {
    +      return analyzeCriticalTimeout;
    +   }
    +
    +   @Override
    +   public Configuration setAnalyzeCriticalTimeout(long timeout) {
    +      this.analyzeCriticalTimeout = timeout;
    +      return this;
    +   }
    +
    +   @Override
    +   public long getAnalyzeCriticalCheckPeriod() {
    +      if (analyzeCriticalCheckPeriod == ActiveMQDefaultConfiguration.getAnalyzeCriticalCheckPeriod()) {
    --- End diff --
    
    I was more getting at should the defaulting logic of using the timeout if the value is not set live in the config parser?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---