activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1466: ARTEMIS-1353 ensure replication packet ...
Date Wed, 16 Aug 2017 19:43:26 GMT
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1466

    ARTEMIS-1353 ensure replication packet order

    Incorrect ordering of replication packets may happen because of
    useExecutor parameter in the sendReplicatePacket method.
    ReplicationStartSyncMessage packets are sent as first, but they are sent
    with useExecutor=true. Although ReplicationSyncFileMessage packets are
    sent after ReplicationStartSyncMessage packets, they are sent with
    useExecutor=false. So sending of ReplicationStartSyncMessage packets is
    scheduled to executor and there is no guarantee when the task will be
    executed, whereas ReplicationStartSyncMessage packets are sent
    immediately.
    
    The solution is to wait for an ack for ReplicationStartSyncMessages.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1353

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1466
    
----
commit a9f3dcfb10314763d5feeff6d56de9694cc0ede1
Author: Justin Bertram <jbertram@apache.org>
Date:   2017-08-16T17:08:31Z

    ARTEMIS-1353 ensure replication packet order
    
    Incorrect ordering of replication packets may happen because of
    useExecutor parameter in the sendReplicatePacket method.
    ReplicationStartSyncMessage packets are sent as first, but they are sent
    with useExecutor=true. Although ReplicationSyncFileMessage packets are
    sent after ReplicationStartSyncMessage packets, they are sent with
    useExecutor=false. So sending of ReplicationStartSyncMessage packets is
    scheduled to executor and there is no guarantee when the task will be
    executed, whereas ReplicationStartSyncMessage packets are sent
    immediately.
    
    The solution is to wait for an ack for ReplicationStartSyncMessages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message