activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #:
Date Tue, 22 Aug 2017 12:19:30 GMT
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/commit/2b5a3daf6ddedee71219766803ce9da405529483#commitcomment-23792932
  
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
    In artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
on line 264:
    I don't think this was making any allocations.  Was it?
    
    
    I don't see anything wrong with merging the PR.  I just wanted to know what did you see.
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message