activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1471: ARTEMIS-1350 - Update management consol...
Date Fri, 18 Aug 2017 12:52:45 GMT
Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1471#discussion_r133951178
  
    --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/consumers.html ---
    @@ -44,9 +44,30 @@
                         </button>
                     </form>
                 </div>
    +
    +            <div class="pull-right">
    +              <form class="form-inline">
    +                <button class="btn-danger" ng-disabled="gridOptions.selectedItems.length
== 0"
    +                        ng-click="deleteDialog = true"
    +                        title="Close the selected Consumer">
    +                  <i class="icon-remove"></i> Close
    +                </button>
    +                &nbsp;&nbsp;&nbsp;
    +              </form>
    +            </div>
             </div>
         </div>
     
    +    <div hawtio-confirm-dialog="deleteDialog"
    +          ok-button-text="Close"
    +          on-ok="closeConsumer()">
    +       <div class="dialog-body">
    +         <p>You are about to close the selected session: {{gridOptions.selectedItems[0].id}}
    --- End diff --
    
    Actually, the button does seem to be disabled.  It just isn't visibly disabled, e.g. greyed
out etc... I think this is OK.  I have some minor layout fixes and the comment from @michaelandrepearce
.  I will squash and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message