activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1468: ARTEMIS-1354 Critical IO Error on AIO w...
Date Thu, 17 Aug 2017 15:25:51 GMT
Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1468#discussion_r133746311
  
    --- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
---
    @@ -304,7 +304,7 @@ public void run() {
              try {
                 libaioFile.write(position, bytes, buffer, this);
              } catch (IOException e) {
    -            callback.onError(-1, e.getMessage());
    --- End diff --
    
    What difference does it make?  The server is shutting down.  Also we don't do this for
NIO: https://github.com/apache/activemq-artemis/blob/master/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSequentialFile.java#L286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message