activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michaelandrepearce <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...
Date Tue, 08 Aug 2017 06:47:46 GMT
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1447#discussion_r131832623
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
    @@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final boolean direct)
{
                    if (intermediateMessageReferences.isEmpty() && messageReferences.isEmpty()
&& !pageIterator.hasNext() && !pageSubscription.isPaging()) {
                       // We must block on the executor to ensure any async deliveries have
completed or we might get out of order
                       // deliveries
    -                  if (flushExecutor() && flushDeliveriesInTransit()) {
    +                  if (internalFlushExecutor(500, false) && flushDeliveriesInTransit())
{
    --- End diff --
    
    Why 500 why not 100, if the issue was previously it was taking too long surely we want
this as small as safely possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message