activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cshannon <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1445: ARTEMIS-1327 - Support checked exceptions in A...
Date Mon, 07 Aug 2017 18:10:23 GMT
Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1445
  
    @clebertsuconic - So I just realized that I don't think we want to swallow exceptions.
 If there's an exception in the plugin don't we want it to propagate?  There are 2 cases for
exceptions, the first is a buggy plugin and that just means the plugin should be fixed.  The
second is if there is an actual error and I think that error should be propagated and not
just logged.
    
    For example, one of my use cases for this is I want to validate clientIds.  So I want
to throw an exception and reject a clientId in the beforeSessionMetadataAdded method if it
doesn't meet some criteria and have it propagated back to the client.  (There's actually another
Jira I need to open to make this work properly to make sure the exception is thrown back to
the client).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message