activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cshannon <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1445: ARTEMIS-1327 - Support checked exceptio...
Date Mon, 07 Aug 2017 15:10:42 GMT
Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1445#discussion_r131680131
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
---
    @@ -537,7 +540,11 @@ public void connectionDestroyed(final Object connectionID) {
           if (conn != null && !conn.connection.isSupportReconnect()) {
              RemotingConnection removedConnection = removeConnection(connectionID);
              if (removedConnection != null) {
    -            server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterDestroyConnection(removedConnection)
: null);
    +            try {
    +               server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterDestroyConnection(removedConnection)
: null);
    +            } catch (Exception e) {
    +               throw new IllegalStateException("Error executing afterDestroyConnection
plugin method: " + e.getMessage(), e);
    --- End diff --
    
    Yep, good point, i'll switch it and push up a new version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message