activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1445: ARTEMIS-1327 - Support checked exceptio...
Date Mon, 07 Aug 2017 15:05:26 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1445#discussion_r131678813
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
---
    @@ -514,8 +514,11 @@ public void connectionCreated(final ActiveMQComponent component,
           }
     
           ConnectionEntry entry = protocol.createConnectionEntry((Acceptor) component, connection);
    -      server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterCreateConnection(entry.connection)
: null);
    -
    +      try {
    +         server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.afterCreateConnection(entry.connection)
: null);
    +      } catch (Exception e) {
    +         throw new IllegalStateException("Error executing afterCreateConnection plugin
method: " + e.getMessage(), e);
    --- End diff --
    
    shouldn't you just log on this case...
    
    I would expect any failures on the broker plugin to just be logged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message