activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #1444: ARTEMIS-1326 testTimeOnTimedBuffer incorrect t...
Date Mon, 07 Aug 2017 14:25:51 GMT
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1444
  
    The test was correct before.
    
    This write here would flush the buffer right away and a new write would be issued:
    https://github.com/apache/activemq-artemis/blob/f12116d5a54fbaa2f2507293bb6d524ec3012fa7/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java#L195-L196
    
    
    The burst cannot complete in less than the timeout.. otherwise the timed buffer is not
timing...
    
    I would revert this change... or provide more info on where it failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message