Return-Path: <dev-return-60306-archive-asf-public=cust-asf.ponee.io@activemq.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 00BED200CCB
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 20 Jul 2017 23:45:47 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id F307516AED0; Thu, 20 Jul 2017 21:45:46 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 4616C16AE7F
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 20 Jul 2017 23:45:46 +0200 (CEST)
Received: (qmail 6969 invoked by uid 500); 20 Jul 2017 21:45:45 -0000
Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:dev@activemq.apache.org>
List-Id: <dev.activemq.apache.org>
Reply-To: dev@activemq.apache.org
Delivered-To: mailing list dev@activemq.apache.org
Received: (qmail 6958 invoked by uid 99); 20 Jul 2017 21:45:45 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jul 2017 21:45:45 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 0B2D3DFC33; Thu, 20 Jul 2017 21:45:43 +0000 (UTC)
From: jdanekrh <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-1380-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-1380-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #1380: ARTEMIS-1265 JaCoCo profile for getting...
Content-Type: text/plain
Message-Id: <20170720214544.0B2D3DFC33@git1-us-west.apache.org>
Date: Thu, 20 Jul 2017 21:45:43 +0000 (UTC)
archived-at: Thu, 20 Jul 2017 21:45:47 -0000

Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1380#discussion_r128638701
  
    --- Diff: pom.xml ---
    @@ -948,6 +966,169 @@
                 <skipTests>true</skipTests>
              </properties>
           </profile>
    +      <!-- This profile generates jacoco coverage files. To generate html report use "-Pjacoco-generate-report" -->
    +      <profile>
    +         <id>jacoco</id>
    +         <dependencies>
    +            <dependency>
    +               <groupId>org.jacoco</groupId>
    +               <artifactId>org.jacoco.core</artifactId>
    +            </dependency>
    +         </dependencies>
    +         <build>
    +            <plugins>
    +               <plugin>
    +                  <groupId>org.jacoco</groupId>
    +                  <artifactId>jacoco-maven-plugin</artifactId>
    +                  <executions>
    +                     <execution>
    +                        <id>jacoco-prepare</id>
    +                        <phase>validate</phase>
    +                        <goals>
    +                           <goal>prepare-agent</goal>
    +                        </goals>
    +                        <configuration>
    +                           <destFile>${project.build.directory}/jacoco.exec</destFile>
    +                           <!-- Jacoco sets this property with agent configuration.
    +                           This property is passed to maven-surefire-plugin -->
    +                           <propertyName>jacoco.agent</propertyName>
    +                        </configuration>
    +                     </execution>
    +                     <execution>
    +                        <id>merge</id>
    +                        <phase>none</phase>
    +                        <goals>
    +                           <goal>merge</goal>
    +                        </goals>
    +                     </execution>
    +                  </executions>
    +                  <configuration>
    +                     <fileSets>
    +                        <fileSet implementation="org.apache.maven.shared.model.fileset.FileSet">
    +                           <directory>${activemq.basedir}</directory>
    +                           <includes>
    +                              <include>**/*.exec</include>
    --- End diff --
    
    The plugin looks at all dependencies of the current module and examines them for jacoco.exec files.
    
    New module or reusing existing one.
    
    As I said, this was just a suggestion. Whatever works is fine with me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---