Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 33E41200CC1 for ; Mon, 10 Jul 2017 21:47:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3266E163ACC; Mon, 10 Jul 2017 19:47:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 787E4163AC9 for ; Mon, 10 Jul 2017 21:47:31 +0200 (CEST) Received: (qmail 74346 invoked by uid 500); 10 Jul 2017 19:47:30 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 74335 invoked by uid 99); 10 Jul 2017 19:47:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2017 19:47:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2ECA8E024D; Mon, 10 Jul 2017 19:47:30 +0000 (UTC) From: Odyldzhon To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #1389: ARTEMIS-1272 Artemis incorrectly handle... Content-Type: text/plain Message-Id: <20170710194730.2ECA8E024D@git1-us-west.apache.org> Date: Mon, 10 Jul 2017 19:47:30 +0000 (UTC) archived-at: Mon, 10 Jul 2017 19:47:32 -0000 Github user Odyldzhon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1389#discussion_r126518160 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/MqttAcknowledgementTest.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.artemis.tests.integration.mqtt; + +import java.util.LinkedList; +import java.util.concurrent.TimeUnit; + +import org.apache.activemq.artemis.tests.integration.mqtt.imported.MQTTTestSupport; +import org.awaitility.Awaitility; +import org.awaitility.core.ConditionTimeoutException; +import org.eclipse.paho.client.mqttv3.IMqttDeliveryToken; +import org.eclipse.paho.client.mqttv3.MqttCallback; +import org.eclipse.paho.client.mqttv3.MqttClient; +import org.eclipse.paho.client.mqttv3.MqttConnectOptions; +import org.eclipse.paho.client.mqttv3.MqttException; +import org.eclipse.paho.client.mqttv3.MqttMessage; +import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence; +import org.jgroups.util.UUID; +import org.junit.After; +import org.junit.Test; + +public class MqttAcknowledgementTest extends MQTTTestSupport { + + private volatile LinkedList messageIds = new LinkedList<>(); + private volatile boolean messageArrived = false; + + private MqttClient subscriber; + MqttClient sender; + + @After + public void clean() throws MqttException { + messageArrived = false; + messageIds.clear(); + if (subscriber.isConnected()) { + subscriber.disconnect(); + } + if (sender.isConnected()) { + sender.disconnect(); + } + subscriber.close(); + sender.close(); + } + + @Test(timeout = 300000) + public void testAcknowledgementQOS1() throws MqttException { + test(1); + } + + @Test(timeout = 300000, expected = ConditionTimeoutException.class) + public void testAcknowledgementQOS0() throws MqttException { + test(0); + } + + private void test(int qos) throws MqttException { + String subscriberId = UUID.randomUUID().toString(); + String senderId = UUID.randomUUID().toString(); + String topic = UUID.randomUUID().toString(); + + subscriber = createMqttClient(subscriberId); + subscriber.subscribe(topic, qos); + + sender = createMqttClient(senderId); + sender.publish(topic, UUID.randomUUID().toString().getBytes(), qos, false); + sender.publish(topic, UUID.randomUUID().toString().getBytes(), qos, false); + + Awaitility.await().atMost(5_000, TimeUnit.MILLISECONDS).until(() -> messageIds.size() == 2); + + subscriber.messageArrivedComplete(messageIds.getLast(), qos); + subscriber.disconnect(); + subscriber.close(); + messageArrived = false; + + Awaitility.await().atMost(60_000, TimeUnit.MILLISECONDS).until(() -> { + try { + subscriber = createMqttClient(subscriberId); + return true; + } catch (MqttException e) { + return false; + } + }); --- End diff -- done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---