activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdanekrh <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Date Tue, 18 Jul 2017 21:01:12 GMT
GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1409

    ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that

    This change results in many more tests being run. Previously, 662 tests
    were executed. Now, 1166 tests is executed. The running time has increased
    from ~20 minutes to ~50 minutes.
    
    Before
    
    > Tests run: 662, Failures: 14, Errors: 4, Skipped: 1
    
    After
    
    > Tests run: 1166, Failures: 38, Errors: 1, Skipped: 2
    
    (the second commit in the PR disables one of the erroring tests, because it tests feature
that Artemis does not implement)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_fix_exit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1409
    
----
commit 4bf4ec552612f5001897b195d27c61e48efdb00e
Author: Jiri Danek <jdanek@redhat.com>
Date:   2017-07-17T09:51:55Z

    ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
    
    This change results in many more tests being run. Previously, 662 tests
    were executed. Now, 1166 tests is executed. The running time has increased
    from ~20 minutes to ~50 minutes.

commit 3ec9137a4656a5c7b35a469cde34ce2ab86177b8
Author: Jiri Danek <jdanek@redhat.com>
Date:   2017-07-18T11:55:07Z

    ARTEMIS-1276 disable MessageEvictionTest
    
    The test is broken. It can be fixed by doing
    
    ```java
    FakeTransportConnector(URI uri) {
       setServer(new TransportServer {
         @Override
         public URI getConnectURI() {
            return uri;
         }
    but then the test would fail because message
     eviction is not supported by Artemis.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message