activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <>
Subject [GitHub] activemq-artemis pull request #1394: ARTEMIS-1268 Fix LargeMessages over STO...
Date Mon, 10 Jul 2017 15:44:18 GMT
Github user clebertsuconic commented on a diff in the pull request:
    --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/
    @@ -389,7 +389,7 @@ public void sendInternalLarge(CoreMessage message, boolean direct)
throws Except
           long id = storageManager.generateID();
           LargeServerMessage largeMessage = storageManager.createLargeMessage(id, message);
    -      byte[] bytes = new byte[message.getBodyBuffer().writerIndex() - CoreMessage.BODY_OFFSET];
    +      byte[] bytes = new byte[message.getBodyBuffer().readableBytes()];
    --- End diff --
    it would be safer to do it this way.. I'm sure it wouldn't affect other messages.. 
    message.getBodyBuffer() may affect the position of a message if it's on a topic with many

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message