activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaohoward <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #1378: ARTEMIS-1261 Adjust default confirmatio...
Date Thu, 29 Jun 2017 04:06:24 GMT
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1378

    ARTEMIS-1261 Adjust default confirmation-window-size for bridges

    The default id-cache-size is 20000 and the default
    confirmation-window-size is 1MB. It turns out the 1MB
    size is too small for id-cache-size.
    
    To fix it we adjust the confirmation-window-size to 10MB. Also
    a test is added to guarantee it won't break this rule when this
    default value is to be changed to any new value.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis jmaster_idCacheSz

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1378
    
----
commit 7e0f8fd6bb4c9325c81fa9df8668cfdeea650514
Author: Howard Gao <howard.gao@gmail.com>
Date:   2017-06-29T04:03:38Z

    ARTEMIS-1261 Adjust default confirmation-window-size for bridges
    
    The default id-cache-size is 20000 and the default
    confirmation-window-size is 1MB. It turns out the 1MB
    size is too small for id-cache-size.
    
    To fix it we adjust the confirmation-window-size to 10MB. Also
    a test is added to guarantee it won't break this rule when this
    default value is to be changed to any new value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message